Install vst3sdk via CMake's FetchContent, and update to latest version #26031
+24
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing it via FetchContent should make it easier to update the version, without needing to upload things to S3.
Those
commonstringconvertwere added in version 3.7.12. Version 3.7.12 does not build without listing them in sdk/CMakeLists.txt; version 3.7.11 does not build with them. So this is a breaking change for whoever is still using version 3.7.11. On the other hand, it is a fix for those who downloaded the latest version from the Steinberg website recently (3.7.12 has been out since July 26th).