-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #15726 (Glissando & Bends): Some elements are lost when changing time signature #26028
base: master
Are you sure you want to change the base?
Fix #15726 (Glissando & Bends): Some elements are lost when changing time signature #26028
Conversation
82aa1be
to
ce9d0aa
Compare
ce9d0aa
to
90b54b8
Compare
aa99482
to
053fc78
Compare
…ignature Backport of musescore#26028
I have changed the way we clone Note's Spanners (outside Note copy constructor) to avoid failing tests. There is a duplicated function (TrackList::cloneAndRebuildSpanners) and lamba function cloneAndRebuildSpannersWrite within write method) because write method is const ( bool write(Score*, const Fraction&) const; ). If we can change this method to "not const" (bool TrackList::write(Score* score, const Fraction& tick) ) we could avoid this duplication. I have not come up with any other way, any hint to avoid function duplication would be appreciated |
…ignature Backport of musescore#26028
053fc78
to
3ae1323
Compare
I have made some additional changes to simplify cloneAndRebuildSpanners function. I have also put it out of the class to avoid code duplication by allowing write method to use it. |
…changing time signature
3ae1323
to
c84e29d
Compare
…ignature Backport of musescore#26028
Resolves: #15726 (Glissando and Bends)
This PR keeps Glissando & Bends when changing time signature: