Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #25457: Style dialog too big by default #26025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WhyMeAgain233
Copy link
Contributor

Resolves: #25457

Reduces the default dialog height, and adds a detection function which automatically resize the dialog if it's too big to display.
According to the discussion, changing only the default height is not enough, so I added adjustment to the device's screen resolution.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@WhyMeAgain233 WhyMeAgain233 force-pushed the 25457-EditStyleDialogSize branch from 2d1966a to 4e8bb6a Compare January 8, 2025 15:22
@avvvvve
Copy link

avvvvve commented Jan 10, 2025

Nice work! Tested using 1024x663 screen resolution on my Macbook and it seems to react appropriately.

One small thing to fix (a regression): The dialog used to open in the center of the screen, but now it opens in the upper left.

image

@DmitryArefiev or @zacjansheski could you test this on other devices/screen sizes?

@zacjansheski
Copy link
Contributor

Checked on MacOS and Windows, looks good (besides the noted non-center on open issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style dialog too big by default; OK/Cancel buttons fall of the screen on smaller screens
3 participants