Big time signatures #25894
Merged
Big time signatures #25894
+2,033
−313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/TimeSigPage.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/TimeSigPage.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/TimeSigPage.qml
Outdated
Show resolved
Hide resolved
mike-spa
force-pushed
the
bigTimeSigs
branch
from
14027c2 to
c9ffb98
Compare
mike-spa
force-pushed
the
bigTimeSigs
branch
5 times, most recently
from
f4cfb3b to
995ffb2
Compare
oktophonie
approved these changes
Jan 13, 2025
This comment was marked as resolved.
This comment was marked as resolved.
|
@rettinghaus No, the placement will be set via the system markings UI which is not quite finished yet. |
This comment was marked as resolved.
This comment was marked as resolved.
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/TimeSigPage.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/TimeSigPage.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/TimeSigPage.qml
Outdated
Show resolved
Hide resolved
src/notation/qml/MuseScore/NotationScene/internal/EditStyle/TimeSigPage.qml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #20480
Resolves: #25687
This PR introduces new engraving options for Big Time Signatures, including:
The new options are available in a new section of the Clef, Time & Key signatures style page (which, by the way, has been completely reimplemented in QML).
This PR does not include logic and/or UI for choosing on which staves the large time signatures should appear (they now appear at the default system object staves). That will be done as part of the System Object feature by @RomanPudashkin.