-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support/use musical font files' x-offset for stems #25050
base: master
Are you sure you want to change the base?
Support/use musical font files' x-offset for stems #25050
Conversation
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
da6e991
to
b9c14b8
Compare
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
0558ca3
to
96f0b26
Compare
6 fonts (Bravura, Emmentaler, Gonville, Leland, MuseJazz and Petaluma, so basically all but the Finale ones) need some special, and different, treatment. Required quite a bit of fine tuning... At least for Emmentaler, Gonville, Leland and MuseJazz (the latter 2 don't need special treatment in my MuseScore 3.7) we might be able to instead just fix their metadata.json and there esp. the Should we ever enable external fonts: the vast majority the ones I tested with (cap1800, Ekmelos, Finale Ash, Finale Engraver, Finale Jazz, Golden Age, Leipzig, Sebastian, Valerio, but not with AloisiusU, AloisiusGrooveU and Legato which has an issue with Attached sample scores for all the current fonts Mu4 support: |
22bed5e
to
4598da8
Compare
Most vtest differences are minor and IMHO harmless and basically an expcted result of ther fine tuning. These certainly are not: |
1e79177
to
d97dd2d
Compare
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
I believe to have found a better way, in my 3.7 PR Jojo-Schmitz#672, by picking on the glyphs But I'm now having a hard time porting all this accross to master, without having to use more special treatment and for more fonts. Even the (identical) metadata changes for Emmentaler and Gonville don't work here?!? Seems I'm missing something that changed in the rendering? I'll push what I have rebased and in a 2nd commit (also to check the vtests), please comment. |
And y-offset the stems for long notes to interfere less with those notes' vertical bars at either edge
d97dd2d
to
2dd7f25
Compare
2dd7f25
to
35f4cdc
Compare
It doesn't seem to make any significant difference with the vtests at all!? Issues with small and/or mirrored notes, single note tremolos and all kind of noteheads that this change shouldn't even touch! Actually I don't really trust those vtests, loading the 'offending' vtest scores into my local build as well as into the artifact show them looking just fine (except for the slurs issue I have with Mu3 too, and on top the single note tremolo issue)!?! |
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
Resolves https://musescore.org/en/node/369769#comment-1261591 See also the port to mu4/master at musescore#25050
Resolves: #25088
Resolves: https://musescore.org/en/node/369769#comment-1261591 where it came up for 3.7. Needs special treatment for Bravura, Emmentaler (particularly bad metadata apparenty), Gonville, Leland, MuseJazz, Petaluma, these fonts' metadata seem to disargee with the stems being offset by half a stem width to the left for upstem notes/chords