Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ruff linter to workflows #33

Merged
merged 2 commits into from
Nov 12, 2024
Merged

add ruff linter to workflows #33

merged 2 commits into from
Nov 12, 2024

Conversation

JHalbauer
Copy link
Contributor

@JHalbauer JHalbauer commented Oct 22, 2024

Add ruff Python linter and formatter to workflows and pre-commit. See docs here

Copy link
Member

@mmacata mmacata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition!

Is it possible to use a different config file than pyproject.toml for ruff?
Some projects already have one for project metadata - then the default linting config from this repository cannot be used, would need to be copied to the existing pyproject.toml but would need to be compared from time to time.
For other projects which don't have one I assume there might be problems with the build if it exists and then some values are not filled. This is only an assumption, I didn't check this.

@JHalbauer
Copy link
Contributor Author

pyproject.toml can be replaced with ruff.toml or .ruff.toml which is done in the following commit. Apparently in a non pyproject.toml file there is no way to configure for exampleblack. It can only be used for ruff and therefore the replacement of ruff, flake8 and pylint in the workflows with ruff has to be done using a pyproject.toml or finding a different solution.

@JHalbauer JHalbauer merged commit 105f4d7 into main Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants