Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure tokenizer can handle equals in attrs (#29) #30

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

Kylea650
Copy link
Contributor

@Kylea650 Kylea650 commented Dec 13, 2024

Closes (#29).

When a '=' was found within an attribute, it would increment the position unnecessarily, causing an out-of-bounds panic when performing: Value: trim(b[pos+1 : i]).

We should instead only do this when we are !inquote.

Test added to cover this.

@muktihari
Copy link
Owner

@Kylea650 Nice catch! Thank you for creating the issue and providing the PR fix.

@muktihari muktihari self-requested a review December 14, 2024 15:56
@muktihari muktihari added the bug Something isn't working label Dec 14, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d4090a1) to head (740acc3).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #30   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          300       302    +2     
=========================================
+ Hits           300       302    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 9b321fc into muktihari:master Dec 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants