Merge pull request #16 from muktihari/dev

Resolve issue #15
muktihari · Mar 5, 2021 · 4475970 · 4475970
2 parents ee87e96 + 97aa44c
commit 4475970
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/boolean/boolean.go b/boolean/boolean.go
@@ -77,7 +77,7 @@ func (v *visitor) arithmetic(xVisitor, yVisitor *visitor, op token.Token) {
 		case token.QUO:
 			v.res, v.kind = fmt.Sprintf("%f", x/y), token.FLOAT
 		case token.REM:
-			v.res, v.kind = fmt.Sprintf("%f", x+y), token.FLOAT
+			v.err = ErrInvalidOperationOnFloat
 		}
 		return
 	}

diff --git a/expr_test.go b/expr_test.go
@@ -5,6 +5,7 @@ import (
 	"testing"
 
 	"github.com/muktihari/expr"
+	"github.com/muktihari/expr/boolean"
 	"github.com/muktihari/expr/float"
 	"github.com/muktihari/expr/integer"
 )
@@ -142,6 +143,7 @@ func TestBool(t *testing.T) {
 		{In: "-4 * -2 > -1", Eq: true},
 		{In: "10 % 2 > -2", Eq: true},
 		{In: "10 % 2 < 1", Eq: true},
+		{In: "10.2 % 2 > 2", Err: boolean.ErrInvalidOperationOnFloat},
 	}
 
 	for _, tc := range tt {