Just split out planning #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed CancelUpgrade; CallDelete must not be wrapped by scoped_lock
…into denys_fixsendpctimestamp
…heir values. If setup wrong, then has to be fixed on caler side
add sending timestamp of the pointcloud if defined
(1) Include boost/bind.hpp in samples with boost::bind (2) Fixed mujindownloaddebug sample (3) updated taskparameter example
…into connectedBodySensorMapping
Add support for querying sensors in connected body.
…into maxPossibleSize # Conflicts: # CMakeLists.txt
Max possible size
Add an endpoint for creating log entries
Add support for unordered_map, deque JSON Ser/Des
add objectType field in RegisterMinViableRegionInfo
Use direct logEntry and logEntryAttachment
Fill in error code and message for timeout exception
use array instead of vector for fixed sized data. removed rotationmat
Determine default values for members that would be indetermine
Add post helper function for formdata
Fix JSON strings
hemangandhi
force-pushed
the
just-split-out-planning
branch
from
1bfe11f to
1188eea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike #1 , this has minimal refactoring.
I don't like this state of the planning client since if you just use the constructor, you make an invalid HTTP planning client, so you have to use the factory function to have a ZMQ client. I'll re-work #1 after this so that we have a simple "just the planning client" without any question of "is there ZMQ."