-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[materia-ui][StepIcon] Add SvgIconOwnProps type to StepIcon props #44337
Merged
+13
−4
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e513ddd
add svgiconprops to stepicon interface
sai6855 85b626e
add tests
sai6855 95da2de
fix-type-issues
sai6855 832243c
fix
sai6855 63bf2b7
docs
sai6855 7fffa51
fix file name
sai6855 085d251
Merge branch 'master' into step-icon
sai6855 463efe7
fix type
sai6855 11a1807
fix type
sai6855 4b3aa99
Merge branch 'step-icon' of https://github.com/sai6855/material-ui in…
sai6855 71c19e9
update types to use SvgIconOwnProps
sai6855 923297e
add comment
sai6855 cc53e00
Merge branch 'master' into step-icon
sai6855 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import * as React from 'react'; | ||
import StepIcon from '@mui/material/StepIcon'; | ||
|
||
<StepIcon icon={<div>icon</div>} />; | ||
<StepIcon icon={<div>icon</div>} titleAccess="title" />; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,14 +2,15 @@ import * as React from 'react'; | |
import { expect } from 'chai'; | ||
import { createRenderer } from '@mui/internal-test-utils'; | ||
import StepIcon, { stepIconClasses as classes } from '@mui/material/StepIcon'; | ||
import SvgIcon from '@mui/material/SvgIcon'; | ||
import describeConformance from '../../test/describeConformance'; | ||
|
||
describe('<StepIcon />', () => { | ||
const { render } = createRenderer(); | ||
|
||
describeConformance(<StepIcon icon={1} />, () => ({ | ||
classes, | ||
inheritComponent: 'svg', | ||
inheritComponent: SvgIcon, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this change is to display https://deploy-preview-44337--material-ui.netlify.app/material-ui/api/step-icon/#props |
||
render, | ||
muiName: 'MuiStepIcon', | ||
testVariantProps: { completed: true }, | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why wait? Can't we fix this now? It's a bug fix, right?