Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with skipping first note, progress counter not starting until 2nd note played, and added end of song callback #227

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

silverhawk184
Copy link

No description provided.

@silverhawk184
Copy link
Author

Fixed another bug!

@xrochoa
Copy link

xrochoa commented Feb 14, 2018

Hey @silverhawk184 ! I was trying to use your fixed branch but it is not working. I tried running the gruntfile and it contains outdated paths (polyfill instead of shim). Even when changing the paths and adding missing files, the build doesn't play any sound. It would be nice to have a version that installs like npm install midi.js to just require the module. I've been waiting for this fix for a long time and I got exited for a minute. I wish I had the time to understand the library to make the updates myself. I hope you are able to find a fix. Thanks

@qk44077907
Copy link

Hi ,@silverhawk184 I replaced your player.js to the original one , there is still a looping bug when playing the midi file

@qk44077907
Copy link

@silverhawk184 sorry, I downloaded to worry version, but the bug skiping the first chord still exist, eventually,to all guys who met this bug: I copied the module in the author's personal project https://galactic.ink/piano/min/app.js (search the keywords Player),it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants