replace custom calls with elasticsearch client gem #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an issue with webrick throwing "invalid URI" for every requests. Took some debugging, but found it. this is related to ruby/webrick#144 . however we can't override the webrick dependency here version, so requires a change in the template |
nvdk
force-pushed
the
feature/elasticsearch-client
branch
from
9375a43
to
9654265
Compare
rationale: Moving to the elasticsearch client removes complexity from our own client (less maintenance) and allows us to benefit from features offered by the client. Specifically: - full elasticsearch api support, which should allow us to implement new features more quickly (like metrics, updating index settings without a complete rebuild, ...) - the ability to set up tracing and logging of http calls - the ability to use connection pooling and persistent connections
faraday can use several http backends for its requests, quick research indicated this to be the most used modern one. it should be easy to switch to one of the other adapters (net http persistent or patron) if this one is not performant enough sources: - https://apisyouwonthate.com/blog/ruby-users-be-wary-of-net-http/ - https://www.elastic.co/guide/en/elasticsearch/client/ruby-api/current/troubleshooting.html#ruby-ts-adapter - https://ruby.libhunt.com/compare-patron-vs-typhoeus - elastic/elasticsearch-ruby#437
use latest template which has a newer webrick version
nvdk
force-pushed
the
feature/elasticsearch-client
branch
from
9654265
to
1996d56
Compare
|
should be ready for testing now, seems to work as expected in the octopus app. needs further testing |
this just causes extra confusion when debugging dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rationale: Moving to the elasticsearch client removes complexity from our own
client (less maintenance) and allows us to benefit from features offered by the
client.
Specifically:
features more quickly (like metrics, updating index settings without a complete rebuild, ...)
Has been tested on the octopus app and seems to be working as expected, but needs further testing.
Confirmed working:
has performance improvements because of better http connection management, needs to be tested under heavy delta load.
NOTE: requires latest version of mu-jruby-template, make sure to pull that when testing/building locally