Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal hand when selecting cards from opponents hand #7850

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

NBKelly
Copy link
Collaborator

@NBKelly NBKelly commented Oct 30, 2024

I think this is a really nice QOL feature. I just have to root out all the cards it applies to.

Essentially, there's not much reason for us to to use lists to pick cards out of our opponents hand unless only a subset of the cards is known. It's both clunky (in our interface) and clunky (in our code).

Some of the cards/systems I can hit (these are all done and this pr is ready):

Demo:
with-revealed-hands.webm

@NBKelly NBKelly marked this pull request as draft October 30, 2024 20:12
@NBKelly
Copy link
Collaborator Author

NBKelly commented Nov 2, 2024

Realized I need a special safeguard for if the target adds cards to hand while things are revealed (ie steelskin draws cards, but there's also a buffer drive on the field and there's a prompt to resolve), so I'm adding that in.

@NBKelly NBKelly marked this pull request as ready for review November 2, 2024 05:31
@NBKelly
Copy link
Collaborator Author

NBKelly commented Nov 2, 2024

steelskin-interaction.webm

Interaction with steelskin - cards get flipped face-down when the runner draws, despite still resolving the consequences of the ability. I'm pretty happy with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant