general overhaul for 5.0.0 #11
Conversation
SwissalpS
commented
Sep 18, 2024
•
SwissalpS
commented
- overhauled English language
- overhauled French language
- adds Spanish locale
- adds German locale
- adds mtt integration testing
- adds github workflow for mtt
- refactores handle_command
- standardizes usage of table.getn() (nothing crucial in this mod)
- standardizes variables to have same format and same name for same purpouse
- DB-fix also adds missing owners to members
- fixes some situations where admins couldn't do things
- fixes display of dynamic admin priv and registration
- alows uppercase for subcommands
- adds valid_password() for cleaner checks
- ensures that existing factions don't get overwritten (via 'API')
- adds disband-hook registration for other mods to get notified of disbanded factions
- overhauled English language - overhauled French language - adds Spanish locale - adds German locale - adds mtt integration testing - adds github workflow for mtt - refactores handle_command - standardizes usage of table.getn() (nothing crucial in this mod) - standardizes variables to have same format and same name for same purpouse - DB-fix also adds missing owners to members - fixes some situations where admins couldn't do things - fixes display of dynamic admin priv and registration - alows uppercase for subcommands - adds valid_password() for cleaner checks - ensures that existing factions don't get overwritten
|
Interesting that mtt workflow doesn't have |
err, the |
|
I'm using Lua 5.4.6 |
|
When executing |
which is irrelevant given minetest uses 5.1 lua (some 5.2 features if on luajit) |
Why would it be irrelevant? Obviously my minetest build is using a version that offers Edit: it is irrelevant now in the sense that it is only used in mtt tests and I've provided a working alternative. |
|
It's irrelevant since minetest officially only uses/supports lua5.1(and luajit), if you have compiled/obtained a build somewhere else thats non standard, that's on you. |
mtt.lua
Outdated
| else | ||
| pd = function(...) for _, v in ipairs({ ... }) do print(dump(v)) end end | ||
| end | ||
| local f, fcc, S = factions, factions.handle_command, factions.S |
There was a problem hiding this comment.
I'd generally recommend against localizing stuff for tests so that it would fail also if some mistake removes/trashes/replaces global or its entries.
There was a problem hiding this comment.
OK, removed local reference f of factions. I left the other two as they are only made public when running mtt and if factions got deleted, errors would already be thrown.
