luacheck with builtin minetest #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BuckarooBanzay
added
enhancement
4 tasks
|
Reminder: for docker image / github action should probably at some point add separate action repo for possible docker builds and reusable actions that define workflow stuff. (didn't plan to actually maintain it long term, just provided for testing / demo etc.) |
S-S-X
reviewed
Feb 12, 2024
|
lunarmodule's luacheck workflow now supports the new standard, i updated the relevant parts, this PR is now ready for review |
BuckarooBanzay
changed the title
|
rebased this with current master, should be ready to review/merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of Concept for lunarmodules/luacheck#108
Uses the docker image from @S-S-X (thanks)