fix: prevent infinite loop when bypassing sendBeacon() requests
#2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
sendBeacon() requestssendBeacon() requests
kettanaito
force-pushed
the
fix/bypass-keepalive-requests
branch
from
117d525
to
17841a7
Compare
4 tasks
Released: v2.6.4 🎉This has been released in v2.6.4! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendBeaconcauses infinite loop with response patching #1216Motivation
Requests issued via the
sendBeaconfunction have immutable headers. Any header but for the known headers will be ignored. This also means that thex-msw-intention: passthroughrequest header set by thebypass()function will be ignored, causing the infinite loop when bypassing an interceptedsendBeaconrequest.Changes
Move the
x-msw-intention: passthroughtoaccept: msw/passthrough. Theacceptheader is always preserved, and it should be safe to rely on it to provision bypassed requests identification.Also fixes the issue where the request bypass header was preserved for passthrough requests in Node.js only.