Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitignore #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

traviskaufman
Copy link
Contributor

This commit introduces a gitignore file into the repo, adding *.log
for files such as npm-debug.log as well as the node_modules/
directory.

This commit introduces a gitignore file into the repo, adding `*.log`
for files such as `npm-debug.log` as well as the `node_modules/`
directory.
@traviskaufman
Copy link
Contributor Author

any feedback on this?

@mscdex
Copy link
Owner

mscdex commented Jul 14, 2015

I generally leave out .gitignore, .npmignore, and other such files from my repos (and keep them local), so I'm +0 on it really...

@msimerson
Copy link

I generally leave out .gitignore, .npmignore, and other such files from my repos

But: social coding. Isn't it generally a good idea to make it easier for others who also work in [forks of] your repo? They don't want to see node_modules and *.log files in their git diff or git status output. That's why the default node repos (generated by GitHub) include a .gitignore.

@linusnorton
Copy link

This would be a sensible thing to merge. Leaving out .gitignore from the repo is... unusual

@DanielRuf
Copy link

This would be a sensible thing to merge. Leaving out .gitignore from the repo is... unusual

Definitely

@DanielRuf
Copy link

That's why the default node repos (generated by GitHub) include a .gitignore.

Exactly

@DanielRuf
Copy link

You forgot .DS_Store ;-)

@mscdex mscdex mentioned this pull request Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants