-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All tasks page with filters #283
Conversation
That's a good starting point, but it needs adjustmens. With current code I found couple of bugs:
|
36d4039
to
237826b
Compare
What do you think about 237826b to avoid render delays. |
It's a good idea! Especially for first launch speed improvement and reduced memory usage on startup. We can add this to Task Lists too. The problem with lag appears again, when Pending page loaded more tasks. |
Nevermind. I've tested it, it's even more laggy. Let's scrap this idea. |
237826b
to
922e69a
Compare
I rebased it onto |
922e69a
to
7fbd708
Compare
With https://github.com/mrvladus/Errands/compare/922e69a6fdbde94049395a6f0960e64243c13859..7fbd70827d584e744c5801ba205d233d7d8684c9, it renders more content when the scroll reaches the last page instead of the bottom. |
7fbd708
to
0293cf1
Compare
I rewrote the code to dynamically render the content using Gtk.ListView |
2c912f4
to
5926021
Compare
About the performance, please see #301. |
I think I found fix for scrolling problem I described earlier. So I can use models for task lists which will allow for filtering and sorting. I wanna experiment with creating only one Task List Page with all tasks and use sidebar rows as filter switches that will show only tasks for that list. Then I think we can make only one page like |
With With the current code of this pull request a |
5926021
to
f2e587c
Compare
I added a filter by text or notes via 0c31b58 |
f2e587c
to
0c31b58
Compare
Oh! Thanks to improve the search box! |
Co-authored-by: Vlad Krupinskii <[email protected]> Signed-off-by: Simó Albert i Beltran <[email protected]>
66ae4f5
to
98de6ef
Compare
I reworked it to have one page with all tasks with filters and sorters. More filters and sorters can be added in a near future with complex widgets or search operators. |
Nice! But I wanted to have separate Today Page where all tasks for today and all overdue tasks will be, 'cause it's most used page for planned tasks. And separate All Tasks Page for all tasks. Ideally, to include search, sort and filters in both of them. Like order by due date, start date, creation date. And put all of the filters toggles inside of the popover menu button in header bar. Today Page sidebar row can act like a filter toggle for all tasks page, so we don't need separate pages, when we click on it - it changes title to "Today" and filters only today and overdue tasks. And when we click on "All Tasks" row it clears today filter and changes title to "All Tasks". Something like that... |
Closing because of #339 |
Fixes #282 because also can sort by priority.