Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling improvements #116

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Error handling improvements #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f412d0e
Error handling improvements
mrrfv Jun 9, 2024
cd4a5ae
Show warning if a request fails
mrrfv Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lib/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ const request = async (url, options) => {
let response;
let data;
let attempts = 0;
let maxAttempts = 50;

while(attempts < 50) {
try {
Expand All @@ -123,10 +124,11 @@ const request = async (url, options) => {
return data;
} catch (error) {
attempts++;
if(attempts >= 50) {
console.warn(`An error occured while making a web request: "${error}", retrying. Attempt ${attempts} of ${maxAttempts}.`)
if(attempts >= maxAttempts) {
// Send a message to the Discord webhook if it exists
await notifyWebhook(`An HTTP error has occurred (${response.status}) while making a web request. Please check the logs for further details.`);
throw new Error(`HTTP error! Status: ${response.status} - ${ 'errors' in data ? data.errors[0].message : JSON.stringify(data) }`);
await notifyWebhook(`An HTTP error has occurred (${response ? response.status : "unknown status"}) while making a web request. Please check the logs for further details.`);
throw new Error(`HTTP error! Status: ${response.status} - ${ (data && 'errors' in data) ? data.errors[0].message : data } - ${error}`);
}
await wait(5000);
}
Expand Down
Loading