Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo of expanded icon class #266

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix typo of expanded icon class #266

merged 1 commit into from
Oct 11, 2023

Conversation

0xSbock
Copy link
Contributor

@0xSbock 0xSbock commented Oct 9, 2023

The css class name is misspelled. Thus, the chevron-down is not rendered.

Class definition in redmine:
https://github.com/redmine/redmine/blob/master/public/stylesheets/application.css#L1668

@mrliptontea
Copy link
Owner

The typo came from the source when these icon classes were introduced - https://github.com/redmine/redmine/blob/4.1.0/public/stylesheets/application.css#L1530

So for backward-compatibility they will need to be duplicated in PurpleMine. Can I ask that you add the fix as a new line and leave the old, and then build the project and include compiled application.css in the Pull Request - I could then add a new release with a fix.

@0xSbock
Copy link
Contributor Author

0xSbock commented Oct 9, 2023

Hey :) thanks for the quick response!
Sorry i didn't catch that this could lead to backward compatibility issues.
I force-pushed a new version of the fix to my branch which includes the fix and the typo, as well as a comment.

I wasn't sure if i should include the application.css in the same commit. If you want me split it up i can do this tomorrow :)

@mrliptontea mrliptontea merged commit bc5965a into mrliptontea:master Oct 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants