Allow user to specify zoomWrapperTitle in thumbnail gallery #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi mindprojects,
I downloaded your jqZoom today and have been playing around with it as I'm hoping to use it on my website. One piece of functionality that I needed was missing, so I've added it and committed it here in case you want to merge the change. Full details below...
Commit details:
Check for user-specified zoom wrapper title when swapping the main image with a thumbnail image;
Set and show the title accordingly
Full details:
I'm trying out jqZoom with one main zoomable image and a bunch of thumbnails below it.
Here's an example of a test page:
http://rubydemure.com/sandbox/product.php?pid=2
Some of the thumbnails have a title associated with them. However, as I clicked on thumbnails and they were successfully swapped with the main image, the TITLE in the pop-up zoom window was not updated.
I have added a few lines of code to the "core" JS script to check if the user specified a zoomWrapperTitle and if so (and if title is turned on in the main options), it sets the title in the zoom window and shows it.
Here's an example of an element with the title set:
I hope this is helpful - I thought I'd try to contribute something :-)
Kindest regards,
Darina