Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify zoomWrapperTitle in thumbnail gallery #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darinaprior
Copy link

Hi mindprojects,

I downloaded your jqZoom today and have been playing around with it as I'm hoping to use it on my website. One piece of functionality that I needed was missing, so I've added it and committed it here in case you want to merge the change. Full details below...

Commit details:
Check for user-specified zoom wrapper title when swapping the main image with a thumbnail image;
Set and show the title accordingly

Full details:
I'm trying out jqZoom with one main zoomable image and a bunch of thumbnails below it.
Here's an example of a test page:
http://rubydemure.com/sandbox/product.php?pid=2

Some of the thumbnails have a title associated with them. However, as I clicked on thumbnails and they were successfully swapped with the main image, the TITLE in the pop-up zoom window was not updated.

I have added a few lines of code to the "core" JS script to check if the user specified a zoomWrapperTitle and if so (and if title is turned on in the main options), it sets the title in the zoom window and shows it.
Here's an example of an element with the title set:

I hope this is helpful - I thought I'd try to contribute something :-)
Kindest regards,
Darina

Check for user-specified zoom wrapper title when swapping the main image with a thumbnail image;
Set and show the title accordingly
@darinaprior
Copy link
Author

Sorry - I didn't format that sample code correctly. Here it is again...

<div>
<a href="javascript:void(0);" 
    rel="{
        gallery: 'MYGALLERY', 
        smallimage: 'MYSMALLIMAGE.jpg', 
        largeimage: 'MYLARGEIMAGE.jpg', 
        zoomWrapperTitle: 'THIS IS MY ZOOM TITLE'
    }">
    <img src="MYTHUMBIMAGE.jpg">
</a>
</div>

@mrenzidev
Copy link
Owner

Thanks Darina,
for your contribute to jqzoom, i'll check it out.

All the best
Marco Renzi

2012/2/21 Darina Prior <
[email protected]

Hi mindprojects,

I downloaded your jqZoom today and have been playing around with it as I'm
hoping to use it on my website. One piece of functionality that I needed
was missing, so I've added it and committed it here in case you want to
merge the change. Full details below...

Commit details:
Check for user-specified zoom wrapper title when swapping the main image
with a thumbnail image;
Set and show the title accordingly

Full details:
I'm trying out jqZoom with one main zoomable image and a bunch of
thumbnails below it.
Here's an example of a test page:
http://rubydemure.com/sandbox/product.php?pid=2

Some of the thumbnails have a title associated with them. However, as I
clicked on thumbnails and they were successfully swapped with the main
image, the TITLE in the pop-up zoom window was not updated.

I have added a few lines of code to the "core" JS script to check if the
user specified a zoomWrapperTitle and if so (and if title is turned on in
the main options), it sets the title in the zoom window and shows it.
Here's an example of an element with the title set:

      <a href="javascript:void(0);"
           rel="{
                   gallery: 'MYGALLERY',
                   smallimage: 'MYSMALLIMAGE.jpg',
                   largeimage: 'MYLARGEIMAGE.jpg',
                   zoomWrapperTitle: 'THIS IS MY ZOOM TITLE'
           }">
           <img src="<?php echo $paths['Thumb']; ?>" width="50"

height="50">

I hope this is helpful - I thought I'd try to contribute something :-)
Kindest regards,
Darina

You can merge this Pull Request by running:

git pull https://github.com/darinaprior/jqzoom master

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

  • Allow user to specify zoomWrapperTitle in thumbnail gallery

-- File Changes --

M js/jquery.jqzoom-core.js (12)

-- Patch Links --

https://github.com/mindprojects/jqzoom/pull/1.patch
https://github.com/mindprojects/jqzoom/pull/1.diff


Reply to this email directly or view it on GitHub:
#1


Ing. Marco Renzi
OCP - Oracle certified Mysql Developer
via Zegalara 57
62014 Corridonia(MC)
Mob: 3208377271

"Some superior minds are unrecognized because there is no standard by which
to weigh them."
Joseph Joubert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants