Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade chrome-launcher from 0.15.1 to 1.1.2 #3200

Merged
merged 1 commit into from
Jul 16, 2024
Merged

chore(deps): Upgrade chrome-launcher from 0.15.1 to 1.1.2 #3200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"addons-linter": "6.32.0",
"bunyan": "1.8.15",
"camelcase": "8.0.0",
"chrome-launcher": "0.15.1",
"chrome-launcher": "1.1.2",
"debounce": "1.2.1",
"decamelize": "6.0.0",
"es6-error": "4.1.1",
Expand Down
6 changes: 5 additions & 1 deletion tests/unit/test-extension-runners/test.chromium.js
View file
Open in desktop
Copy link
Contributor Author

@aklinker1 aklinker1 Jul 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the changes to the default flags seem relevant to extensions so I didn't adjust the filtering, but someone more familiar with browsers might want to double check.

Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ describe('util/extension-runners/chromium', async () => {
it('uses the expected chrome flags', () => {
// Flags from chrome-launcher v0.14.0
const expectedFlags = [
'--disable-features=Translate',
'--disable-features=Translate,OptimizationHints,MediaRouter,DialMediaRouteProvider,CalculateNativeWinOcclusion,InterestFeedContentSuggestions,CertificateTransparencyComponentUpdater,AutofillServerCommunication,PrivacySandboxSettings4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any of these cover the new search engines picker? It's quite annoying.

Starting a new profile (web-ext run --target chromium) is basically a whack-a-mole.

'--disable-component-extensions-with-background-pages',
'--disable-background-networking',
'--disable-component-update',
Expand All @@ -66,6 +66,10 @@ describe('util/extension-runners/chromium', async () => {
'--password-store=basic',
'--use-mock-keychain',
'--force-fieldtrials=*BackgroundTracing/default/',
'--disable-hang-monitor',
'--disable-prompt-on-repost',
'--disable-domain-reliability',
'--propagate-iph-for-testing',
];

assert.deepEqual(DEFAULT_CHROME_FLAGS, expectedFlags);
Expand Down