Use markdown instead of HTML in activities.yml #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also support code in the spec link text.
| while (node = iterator.nextNode()) { | ||
| if (node.nodeType === Node.TEXT_NODE) { | ||
| continue; | ||
| function parseMarkdown(markdown, enableLinks = true) { |
There was a problem hiding this comment.
I'm not a fan of defaults being true. Though see below for an alternative structure.
| const fragment = document.createDocumentFragment(); | ||
|
|
||
| // Regex for either code or link (only # or https://) | ||
| const markdownPattern = enableLinks ? /(`([^`]+)`|\[([^\]]+)\]\(((?:#|https:\/\/)[^\)]+)\))/g : /(`([^`]+)`)/g; |
There was a problem hiding this comment.
It looks like you have two obvious phases here: link parsing and code parsing. Could that be two separate passes? That might remove the need for the argument as well.
function expandLinks(md) {
// match then expandInline in the text chunks before appending those.
}
function expandInline(md) {
// match /`([^`]+)`/ and maybe /\b*([^*]+)*\b/ as well.
}There was a problem hiding this comment.
Separately, you don't need the '/g' if you are parsing in chunks like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also support code in the spec link text.