-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR about Kinto Admin UI releasing and packaging #519
Conversation
Something I started thinking about that we haven't addressed in this ADR yet. If kinto-admin has an updated release made, but no code changes have happened in remote-settings that would trigger a new release for remote-settings, how does our action know to publish a new build? Seems like there are 3 options to me:
|
I added a note about this, mentioning the option to have a "fake" |
c6cfafd
to
7e0879a
Compare
Kinto already uses this file to track which version of the admin to pull/build. https://github.com/Kinto/kinto/blob/master/kinto/plugins/admin/VERSION We can do something similar to keep it consistent. |
If the fake package.json trick works, I would do the same in the kinto instead of this VERSION file. Using |
No description provided.