Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR about Kinto Admin UI releasing and packaging #519

Merged
merged 8 commits into from
Jan 18, 2024

Conversation

leplatrem
Copy link
Contributor

No description provided.

@alexcottner
Copy link
Contributor

Something I started thinking about that we haven't addressed in this ADR yet. If kinto-admin has an updated release made, but no code changes have happened in remote-settings that would trigger a new release for remote-settings, how does our action know to publish a new build?

Seems like there are 3 options to me:

  1. Do math. If our previous release of remote-settings happened before the most recent release of kinto-admin, assume we need to do a new build.
  2. Receive a push from kinto-admin actions that would commit an updated version number to us.
  3. Pull from kinto-admin and compare it's current release version with what we have. Then update our version number after a release goes out.

@leplatrem
Copy link
Contributor Author

Something I started thinking about that we haven't addressed in this ADR yet. If kinto-admin has an updated release made, but no code changes have happened in remote-settings that would trigger a new release for remote-settings, how does our action know to publish a new build?

I added a note about this, mentioning the option to have a "fake" package.json file so that Dependabot keeps it up-to-date in the Remote Settings repo for us

@leplatrem leplatrem force-pushed the adr-release-admin-ui branch from c6cfafd to 7e0879a Compare January 11, 2024 15:41
@alexcottner
Copy link
Contributor

Kinto already uses this file to track which version of the admin to pull/build. https://github.com/Kinto/kinto/blob/master/kinto/plugins/admin/VERSION

We can do something similar to keep it consistent.

@leplatrem
Copy link
Contributor Author

We can do something similar to keep it consistent.

If the fake package.json trick works, I would do the same in the kinto instead of this VERSION file. Using jq here should be straightforward

@leplatrem leplatrem requested a review from grahamalama January 17, 2024 13:23
@leplatrem leplatrem merged commit 9d3e548 into main Jan 18, 2024
5 checks passed
@leplatrem leplatrem deleted the adr-release-admin-ui branch January 18, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants