gui: add splash screen hook (bug 1845573) #1401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also run linting on file while we're at it
zzzeid
changed the base branch from
main
to
zeid/bug-1845801-remove-unused-modules
zzzeid
force-pushed
the
zeid/bug-1845573-add-splash-screen-on-macos
branch
from
e73e00b
to
71967cd
Compare
zzzeid
changed the base branch from
zeid/bug-1845801-remove-unused-modules
to
main
zzzeid
force-pushed
the
zeid/bug-1845573-add-splash-screen-on-macos
branch
from
71967cd
to
f43ac39
Compare
zzzeid
changed the base branch from
main
to
zeid/bug-1845801-remove-unused-modules
zzzeid
force-pushed
the
zeid/bug-1845573-add-splash-screen-on-macos
branch
from
f43ac39
to
7ba5b80
Compare
zzzeid
changed the title
zzzeid
force-pushed
the
zeid/bug-1845573-add-splash-screen-on-macos
branch
4 times, most recently
from
64946fa
to
7eb24b3
Compare
- create new BUNDLE_WITH_TK class - add required tcl/tk files to "lib" directory in bundle - force resigning of bundle after it is assembled - add splash runtime hook that shows a loading message
zzzeid
force-pushed
the
zeid/bug-1845573-add-splash-screen-on-macos
branch
from
7eb24b3
to
e987a6c
Compare
zzzeid
changed the base branch from
zeid/bug-1845801-remove-unused-modules
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a runtime hook that shows a splash screen informing the user that mozregression is loading.