Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new Fenix components model to move bugs out of Fenix:General #2399

Merged
merged 17 commits into from
Jul 8, 2024

Conversation

benjaminmah
Copy link
Contributor

@benjaminmah benjaminmah commented May 16, 2024

Resolves #2398.

Intended to use the Fenix-specific component classifier model from mozilla/bugbug#4172 to move bugs that already exist in Fenix:General or have been classified in Fenix:General by the general component model to the other Fenix components.

NOTE: Dependent on mozilla/bugbug#4172 to be merged first to use the Fenix-specific component classifier model.

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

…::General` using the `fenixcomponent` model.
@benjaminmah benjaminmah changed the title Implemented reclassification for bugs originally classified as `Fenix… Use the new Fenix components model to move bugs out of Fenix:General May 16, 2024
bugbot/rules/component.py Outdated Show resolved Hide resolved
bugbot/rules/component.py Outdated Show resolved Hide resolved
@marco-c marco-c added the to-be-announced Improvements to be announced: send to dev-platform, firefox-dev and add to EE newsletter label May 23, 2024
@benjaminmah
Copy link
Contributor Author

Results from training general component model with all Fenix bugs labelled as Fenix::General

https://docs.google.com/document/d/11tk2N7A0GxIvA8aWorqt6eSuzKgZQpPG6_8yycH8wmM/edit?usp=sharing

bugbot/rules/component.py Show resolved Hide resolved
bugbot/rules/component.py Outdated Show resolved Hide resolved
@benjaminmah
Copy link
Contributor Author

benjaminmah commented Jun 7, 2024

@suhaibmujahid

The spreadsheet titled "reclassified_bugs_threshold_and_originally_fenix" handles two cases:

  • includes bugs that were originally Fenix::General before being classified by the general model, and were classified as another component with low confidence (does not meet threshold as defined in config.json)
  • omits bugs that were classified as Fenix::General by the general model with low confidence

https://docs.google.com/spreadsheets/d/1MiAhKmdUx_TER7NOPQ7TAzFTfKJrYGsrlAmDe3p13EQ/edit?usp=sharing

… with low confidence and removed bugs that were reclassified with low confidence
@benjaminmah benjaminmah marked this pull request as ready for review July 4, 2024 15:58
bugbot/rules/component.py Outdated Show resolved Hide resolved
bugbot/rules/component.py Outdated Show resolved Hide resolved
bugbot/rules/component.py Outdated Show resolved Hide resolved
bugbot/rules/component.py Outdated Show resolved Hide resolved
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please verify if the result is still similar? Other than that, things looks good to me. Thank you!

bugbot/rules/component.py Outdated Show resolved Hide resolved
bugbot/rules/component.py Outdated Show resolved Hide resolved
bugbot/rules/component.py Outdated Show resolved Hide resolved
@benjaminmah
Copy link
Contributor Author

Could you please verify if the result is still similar? Other than that, things looks good to me. Thank you!

Everything looks good on my end!

Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@suhaibmujahid suhaibmujahid merged commit 474f434 into mozilla:master Jul 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-be-announced Improvements to be announced: send to dev-platform, firefox-dev and add to EE newsletter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new Fenix components model to move bugs out of Fenix:General
3 participants