Refresh: About - seperate components of "hero" #15510
Conversation
- seperate about "hero" into 3 components (intro, feature, pictos) - add alt white and black backgrounds - move images from m24/about folder to mozorg/about/m24 - optimize community and manifesto images
stephaniehobson
added
Needs Review
|
|
||
| <div class="m24-t-light-alt"> | ||
| <div class="m24-c-content"> | ||
| <ul class="m24-t-columns-four"> |
There was a problem hiding this comment.
From here down the contents of this file is pretty much the same as the old hero.html include.
| } | ||
| } | ||
|
|
||
| // columns |
There was a problem hiding this comment.
This column code is the same as before I separated the files.
|
|
||
| // picto | ||
|
|
||
| .mzp-c-picto { |
There was a problem hiding this comment.
The picto code is mostly the same as before I separated the files. I switched to using the grid() function to calculate max-width.
| max-width: grid(9); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I wasn't sure if I should move the column and picto code to their own .scss file or not. It's not being used anywhere else YET. And it's code that hangs off Protocol classes. Maybe it can stay here until the manifesto page is created and we know what is and is not reused.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15510 +/- ##
=======================================
Coverage 78.71% 78.71%
=======================================
Files 156 156
Lines 8197 8197
=======================================
Hits 6452 6452
Misses 1745 1745 ☔ View full report in Codecov by Sentry. |
One-line summary
Early drafts of the manifesto page show the 3 pieces of the "hero" being re-used in different combinations. This PR pre-emptivly separates them into more independent components.
Significant changes and points to review
Issue / Bugzilla link
#14893
Testing
http://localhost:8000/en-US/about/ with refresh switch on
Note: this will thoroughly break the homepage if #15508 has not merged. That's okay. It's expected. #15508 will fix it