Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency urllib3 to v1.26.19 [SECURITY] #458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 19, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
urllib3 (changelog) ==1.26.17 -> ==1.26.19 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-45803

urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like POST) to GET as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.

From RFC 9110 Section 9.3.1:

A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.

Affected usages

Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.

Both of the following conditions must be true to be affected by this vulnerability:

  • If you're using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON)
  • The origin service is compromised and starts redirecting using 303 to a malicious peer or the redirected-to service becomes compromised.

Remediation

You can remediate this vulnerability with any of the following steps:

  • Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7)
  • Disable redirects for services that you aren't expecting to respond with redirects with redirects=False.
  • Disable automatic redirects with redirects=False and handle 303 redirects manually by stripping the HTTP request body.

CVE-2024-37891

When using urllib3's proxy support with ProxyManager, the Proxy-Authorization header is only sent to the configured proxy, as expected.

However, when sending HTTP requests without using urllib3's proxy support, it's possible to accidentally configure the Proxy-Authorization header even though it won't have any effect as the request is not using a forwarding proxy or a tunneling proxy. In those cases, urllib3 doesn't treat the Proxy-Authorization HTTP header as one carrying authentication material and thus doesn't strip the header on cross-origin redirects.

Because this is a highly unlikely scenario, we believe the severity of this vulnerability is low for almost all users. Out of an abundance of caution urllib3 will automatically strip the Proxy-Authorization header during cross-origin redirects to avoid the small chance that users are doing this on accident.

Users should use urllib3's proxy support or disable automatic redirects to achieve safe processing of the Proxy-Authorization header, but we still decided to strip the header by default in order to further protect users who aren't using the correct approach.

Affected usages

We believe the number of usages affected by this advisory is low. It requires all of the following to be true to be exploited:

  • Setting the Proxy-Authorization header without using urllib3's built-in proxy support.
  • Not disabling HTTP redirects.
  • Either not using an HTTPS origin server or for the proxy or target origin to redirect to a malicious origin.

Remediation

  • Using the Proxy-Authorization header with urllib3's ProxyManager.
  • Disabling HTTP redirects using redirects=False when sending requests.
  • Not using the Proxy-Authorization header.

Release Notes

urllib3/urllib3 (urllib3)

v1.26.19

Compare Source

====================

  • Added the Proxy-Authorization header to the list of headers to strip from requests when redirecting to a different host. As before, different headers can be set via Retry.remove_headers_on_redirect.
  • Fixed handling of OpenSSL 3.2.0 new error message for misconfiguring an HTTP proxy as HTTPS. (#&#8203;3405 <https://github.com/urllib3/urllib3/issues/3405>__)

v1.26.18

Compare Source

====================

  • Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot changed the title Update dependency urllib3 to v1.26.18 [SECURITY] Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed Oct 26, 2023
@renovate renovate bot closed this Oct 26, 2023
@renovate renovate bot deleted the renovate/pypi-urllib3-vulnerability branch October 26, 2023 16:37
@renovate renovate bot changed the title Update dependency urllib3 to v1.26.18 [SECURITY] - autoclosed Update dependency urllib3 to v1.26.18 [SECURITY] Oct 26, 2023
@renovate renovate bot reopened this Oct 26, 2023
@renovate renovate bot restored the renovate/pypi-urllib3-vulnerability branch October 26, 2023 22:15
@renovate renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch from 4aa0cd8 to a3bc8c3 Compare October 26, 2023 22:15
@renovate renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch from a3bc8c3 to 20d7569 Compare June 18, 2024 01:26
@renovate renovate bot changed the title Update dependency urllib3 to v1.26.18 [SECURITY] Update dependency urllib3 to v1.26.19 [SECURITY] Jun 18, 2024
@renovate renovate bot changed the title Update dependency urllib3 to v1.26.19 [SECURITY] Update dependency urllib3 to v1.26.19 [SECURITY] - autoclosed Jun 24, 2024
@renovate renovate bot closed this Jun 24, 2024
@renovate renovate bot deleted the renovate/pypi-urllib3-vulnerability branch June 24, 2024 03:15
@renovate renovate bot changed the title Update dependency urllib3 to v1.26.19 [SECURITY] - autoclosed Update dependency urllib3 to v1.26.19 [SECURITY] Jun 24, 2024
@renovate renovate bot reopened this Jun 24, 2024
@renovate renovate bot restored the renovate/pypi-urllib3-vulnerability branch June 24, 2024 09:46
@renovate renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch from 20d7569 to ad6d13e Compare June 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants