fix: ensure /github/branches endpoint returns all branches #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This endoint currently only fetches up to 100 branches from Github as this is the maximum number of objects you can get from a single query to the GraphQL endpoint. But `mozilla-vpn-client` has well over 100 branches, and the `release` branches were being excluded from the query. Fix this by using pagination until all branches have been returned. Issue: mozilla-releng#1392
ahal
force-pushed
the
fix_list_branches
branch
from
1d508dc to
4629767
Compare
jcristau
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endoint currently only fetches up to 100 branches from Github as this is the maximum number of objects you can get from a single query to the GraphQL endpoint.
But
mozilla-vpn-clienthas well over 100 branches, and thereleasebranches were being excluded from the query. Fix this by using pagination until all branches have been returned.Issue: #1392