Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check tc-admin diff retcode #238

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: check tc-admin diff retcode #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e7e09a
Require tc-admin 4.0.2
jcristau Dec 19, 2024
5f08921
ci: check `tc-admin diff` exit code
jcristau Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/base.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
tc-admin>=3.3.1
tc-admin>=4.0.2
taskcluster
attrs # http://www.attrs.org/en/stable/backward-compatibility.html
mozilla-repo-urls
Expand Down
2 changes: 1 addition & 1 deletion requirements/base.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SHA1:9439d42fa1b173594e393bc7a143ac26cffe5ad6
# SHA1:5428978ea2dc6dc1c4142793053ba03fa77517ad
#
# This file is autogenerated by pip-compile-multi
# To update, run:
Expand Down
3 changes: 3 additions & 0 deletions taskcluster/fxci_config_taskgraph/optimizations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,12 @@ def _get_modified_worker_pools(self) -> set[str]:
]
env = os.environ.copy()
if "TASKCLUSTER_PROXY_URL" in env:
# Force tc-admin diff to look at fxci even when we're running on stage
del env["TASKCLUSTER_PROXY_URL"]
env["TASKCLUSTER_ROOT_URL"] = FIREFOXCI_ROOT_URL
proc = subprocess.run(cmd, stdout=subprocess.PIPE, text=True, env=env)
if proc.returncode not in (0, 2):
proc.check_returncode()
lines = [line for line in proc.stdout.splitlines() if line.startswith("!")]

worker_pools = set()
Expand Down
Loading