Skip to content

Commit

Permalink
ci: check tc-admin diff exit code
Browse files Browse the repository at this point in the history
Avoid optimizing out all tasks when the diff fails.
  • Loading branch information
jcristau committed Dec 19, 2024
1 parent 61cd069 commit 850cfc5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions taskcluster/fxci_config_taskgraph/optimizations.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,12 @@ def _get_modified_worker_pools(self) -> set[str]:
]
env = os.environ.copy()
if "TASKCLUSTER_PROXY_URL" in env:
# Force tc-admin diff to look at fxci even when we're running on stage
del env["TASKCLUSTER_PROXY_URL"]
env["TASKCLUSTER_ROOT_URL"] = FIREFOXCI_ROOT_URL
proc = subprocess.run(cmd, stdout=subprocess.PIPE, text=True, env=env)
if proc.returncode not in (0, 2):
proc.check_returncode()
lines = [line for line in proc.stdout.splitlines() if line.startswith("!")]

worker_pools = set()
Expand Down

0 comments on commit 850cfc5

Please sign in to comment.