Add Stripe subplat saml mapping support #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apping # Conflicts: # rules/SAML-configuration-mapping.js
april
suggested changes
May 26, 2020
april
reviewed
May 26, 2020
april
reviewed
May 26, 2020
rules/SAML-configuration-mapping.js
Outdated
| @@ -33,6 +34,33 @@ function (user, context, callback) { | |||
| }; | |||
|
|
|||
| break; | |||
| case 'stripe-subplat': | |||
| // https://bugzilla.mozilla.org/show_bug.cgi?id=1637117 | |||
| var groupToStripeRoleMap = { | |||
There was a problem hiding this comment.
I think we want var here to follow the Auth0 style : https://github.com/mozilla-iam/auth0-deploy#style
There was a problem hiding this comment.
We should change our style then. :)
Const and let are generally how things should be done, and the rest of this code (as well as all of my new code) uses const/let.
There was a problem hiding this comment.
To add, our documentation says:
The primary goal is to follow the style of the Auth0 example rules.
Having looked at the auth0 example rules, it seems like they have all been updated to use const and let. :)
There was a problem hiding this comment.
Ok, I opened #333 to capture that. I'll leave this as is and we can clean this rule up with all the other rules and the documentation.
Reformat groupToStripeRoleMap to be easier to read Change to use dot format for objects Change to use templates instead of string concatenation
|
This rule was already cleaned up, by leaving it this way you’re making it
so it now needs to be cleaned up. :P
On May 27, 2020, at 10:34 AM, Gene Wood <[email protected]> wrote:
*@gene1wood* commented on this pull request.
------------------------------
In rules/SAML-configuration-mapping.js
<#331 (comment)>
:
@@ -33,6 +34,33 @@ function (user, context, callback) {
};
break;
+ case 'stripe-subplat':
+ // https://bugzilla.mozilla.org/show_bug.cgi?id=1637117
+ var groupToStripeRoleMap = {
Ok, I opened #333 <#333>
to capture that. I'll leave this as is and we can clean this rule up with
all the other rules and the documentation.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#331 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYJAHBBKGJ2YPIUDMXATLRTUXJVANCNFSM4NHBLX6Q>
.
|
This is in advance of #333 being completed
|
Ok, I've changed |
april
approved these changes
May 27, 2020
april
added a commit
to april/auth0-deploy
that referenced
this pull request
Jun 9, 2020
* 'master' of https://github.com/mozilla-iam/auth0-deploy: Fix issues with integers, first name, and the usernames hack Add code to set `existsInCIS` and remove min login check A bunch of fixes including: Add newline at EOF Add direct creature of users in CIS from Auth0 Add Stripe subplat saml mapping support (mozilla-iam#331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=1637117