Update buildtest.yml #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me
Am 17. Mai 2024 22:04:55 MESZ schrieb Sebastian Junges ***@***.***>:
…Support latest, which is currently ubuntu 24.04
You can view, comment on, or merge this pull request online at:
#26
-- Commit Summary --
* Update buildtest.yml
-- File Changes --
M .github/workflows/buildtest.yml (2)
-- Patch Links --
https://github.com/moves-rwth/carl-storm/pull/26.patch
https://github.com/moves-rwth/carl-storm/pull/26.diff
--
Reply to this email directly or view it on GitHub:
#26
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
|
I am now confused, because latest is used further below for the test & deploy. Should it then also be used up here? |
|
The tests are split into two categories:
I suggest to simply add |
|
LGTM! Should we merge this after the basesystem? |
|
Tests run through with the updated basesystem now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support latest, which is currently ubuntu 24.04