Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INJICERT-434] compute svg template multibase&sha256 per spec #125

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

vharsh
Copy link
Member

@vharsh vharsh commented Nov 5, 2024

How to use this feature ?

  • If mosip.certify.issuer.svg.template.id feature is set to a valid credential-id in the DB, it's renderMethod's hash digest will be available for templating with the key _renderMethodSVGdigest.
  • This action will only be performed for the VC download requests which download VC 2.0 templates, i.e. have
  • The template authors should use the _renderMethodSVGdigest placeholder in the template to dynamically fill in the SVG template's optional hash digest as per this spec
  • For longer term use, it's recommended that authors hardcode this value in the VC 2.0 template

Config Changes required

  • for a short term (say) when the template for a particular VC is undergoing rapid design changes the System Integrator can choose to set this mosip.certify.issuer.svg.template.id to a valid UUID present in the svg_template table and later hardcode the hashDigest value in the VC template itself to avoid re-evaluation of the hash on each VC download

Template changes required

  • VC 2.0 template authors can optionally include the VC2.0 renderMethod key with valid values if they want to add support for VC rendering, by default this feature is turned off.

ref: https://w3c-ccg.github.io/vc-render-method/#svgrenderingtemplate

Copy link
Contributor

@jainhitesh9998 jainhitesh9998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add test cases here?

@jainhitesh9998 jainhitesh9998 merged commit 7151588 into mosip:develop Nov 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants