MOSIP-30099,MOSIP-30009,MOSIP-30026,MOSIP-19740:Bugfixes for admin-service #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmsonkusare
changed the title
yashmsonkusare
force-pushed
the
patch-bugs
branch
from
50a91df
to
7964802
Compare
yashmsonkusare
changed the title
yashmsonkusare
changed the title
…sponse Signed-off-by: Yash S <[email protected]>
…ailable/gender/residenceStatus data Signed-off-by: Yash S <[email protected]>
Signed-off-by: Yash S <[email protected]>
…t and if not will generate new randomId Signed-off-by: Yash S <[email protected]>
yashmsonkusare
force-pushed
the
patch-bugs
branch
from
0de7303
to
87cb0d4
Compare
dhanendra06
approved these changes
Apr 17, 2024
ase-101
reviewed
Apr 17, 2024
| String attribute = keyValues.getAttribute(); | ||
| Object value = keyValues.getValue(); | ||
|
|
||
| if ("residenceStatus".equals(attribute)) { |
There was a problem hiding this comment.
This should not be handled here instead it should be checked in the mvel script. As of today if the provided values do not match any condition it returns "000"
ase-101
reviewed
Apr 17, 2024
| @@ -134,7 +136,13 @@ public BlocklistedWordsResponseDto getAllBlocklistedWordsBylangCode(String langC | |||
| throw new DataNotFoundException(BlocklistedWordsErrorCode.NO_BLOCKLISTED_WORDS_FOUND.getErrorCode(), | |||
| BlocklistedWordsErrorCode.NO_BLOCKLISTED_WORDS_FOUND.getErrorMessage()); | |||
| } | |||
|
|
|||
| private void validateLangCode(String langCode) { | |||
There was a problem hiding this comment.
Are we duplicating the code here?
There was a problem hiding this comment.
No, we are not duplicating the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.