Add passthrough touch support for windows native multi-touch #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZigZagT
force-pushed
the
master
branch
5 times, most recently
from
2e73fb1
to
0c81f2b
Compare
|
This is really cool and long awaited feature 😀 when we can expect this to make it to the official releases? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for sending touch events to Sunshine hosts directly.
This has been asked in multiple issues (incomplete list)
Summary of changes
Once turned on, touch events will be routed to Sunshine hosts via the
LiSendTouchEventAPI, and appears as natively multi touch events on Windows.When passthrough mode is enabled, the pop-up keyboard would require 5 fingers tap to fire up. This avoids conflicting with windows native gestures. (According to the touch-gestures-for-windows, windows has native touch gestures use up to 4 fingers, so 5 fingers tap provides a good guarantee). Windows also offers a built-in on-screen touch keyboard when multi-touch events are received, making the pop-up keyboard less crucial than before.
A performance tweak (turning off UIScrollView delaysContentTouches). While I was on this I noticed the "pin & pan & scroll" feature in absolute touch mode brings in unwanted delay due to the default settings of ScrollView, which might have caused the following issues regarding delays:
The delay It is pretty noticeable in windows paint app.