build(deps): use submodules for libcec #894
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't believe this failure is caused by my changes... or maybe I missed something? 23a6e5471cec: Pulling fs layer
4a26899c0f92: Pulling fs layer
393d2addb2a5: Pulling fs layer
Status: Downloaded newer image for cgutman/moonlight-embedded-packaging:rpi-buster_4deffd7c9f2e190e
docker.io/cgutman/moonlight-embedded-packaging:rpi-buster_4deffd7c9f2e190e
Using pre-built Docker image - cgutman/moonlight-embedded-packaging:rpi-buster_4deffd7c9f2e190e
WARNING: The requested image's platform (linux/arm/v7) does not match the detected host platform (linux/amd64/v3) and no specific platform was requested
Checking out e50a722f69d58f28d3d950a017ba1ffa4b9e6af7
Cloning into 'moonlight-embedded'...
fatal: reference is not a tree: e50a722f69d58f28d3d950a017ba1ffa4b9e6af7
Command exited with code 128
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
libcecas a submodule (at last released version). I confirmed thececloader.hfile is identical..gitignoreto make using CLion as an IDE easierThis PR should be squashed and merged. I had to remove
libcecin one commit and add the submodule in a second commit.Purpose
It will be easier to know the source of the third party code. Updates could also get easier if dependabot or renovate bot is added.
Additional Info
I was also going to add https://github.com/aizvorski/h264bitstream as a submodule, but I noticed you have a custom version of https://github.com/moonlight-stream/moonlight-embedded/blob/master/third_party/h264bitstream/h264_stream.c
For
ilclientI didn't find an official git location for the library.