Option type

[tonyfettes]

No description provided.

[peter-jerry-ye-code-review]

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are three observations from the git diff output:

1. Inconsistent Spacing in Bitwise Operators:
   The spacing around bitwise_and and bitwise_or was inconsistent in the original code. The diff fixes this by removing the extra spaces (bitwise_and : 13 → bitwise_and: 13 and bitwise_or : 12 → bitwise_or: 12). This is a good change for consistency, but it’s worth ensuring that this spacing convention is applied uniformly across the entire codebase.

2. Introduction of optional_parameter_label:
   A new rule optional_parameter_label was added to handle parameters with a question_operator. This is a good addition for clarity and modularity, but it’s important to verify that all existing code paths that previously relied on parameter_label with a question_operator are updated to use optional_parameter_label instead. This ensures backward compatibility and avoids potential parsing issues.

3. Precedence for function_type:
   The function_type rule was updated to use prec.right, which ensures right associativity for function types. This is a good change for correctness, especially when dealing with nested function types. However, it’s important to test this change thoroughly to ensure it doesn’t introduce unintended behavior in complex type expressions.

These changes improve the grammar and its consistency, but they should be tested rigorously to avoid regressions.

Copilot reviewed 2 out of 5 changed files in this pull request and generated no comments.

Files not reviewed (3)

• src/grammar.json: Language not supported
• src/node-types.json: Language not supported
• test/corpus/type.txt: Language not supported