Fixes undefined variable $cm

Fixes test: core_calendar\container_test::test_delete_module_delete_events
moodleou · Jul 25, 2023 · a410bcb · a410bcb
1 parent 68adb39
commit a410bcb
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/lib.php b/lib.php
@@ -164,14 +164,13 @@ function oublog_delete_instance($oublogid) {
     // instances
     $DB->delete_records('oublog_instances', array('oublogid'=>$oublog->id));
 
+    if (!$cm = get_coursemodule_from_instance('oublog', $oublog->id)) {
+        throw new moodle_exception('invalidcoursemodule');
+    }
+
     // Fulltext search data
     require_once(dirname(__FILE__).'/locallib.php');
     if (oublog_search_installed()) {
-        $moduleid=$DB->get_field('modules', 'id', array('name'=>'oublog'));
-        $cm=$DB->get_record('course_modules', array('module'=>$moduleid, 'instance'=>$oublog->id));
-        if (!$cm) {
-            throw new moodle_exception('invalidcoursemodule');
-        }
         local_ousearch_document::delete_module_instance_data($cm);
     }