Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better integration tests, with correct exit status checks #161

Merged
merged 1 commit into from
May 14, 2024

Conversation

stronk7
Copy link
Member

@stronk7 stronk7 commented May 13, 2024

There were a few problems with the integration checks, not properly detecting & asserting the expected exit statuses. Plus some problem using runner.os that uses different names (Linux, Windows, macOS), so switching to matrix.os

Now they are better checked, with some output added to explain the problem when the script runs.

@stronk7 stronk7 force-pushed the better_integration_tests_exit_codes branch from a0bef66 to 965f217 Compare May 13, 2024 15:45
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.90%. Comparing base (1ec84f4) to head (cb7f4ad).

❗ Current head cb7f4ad differs from pull request most recent head ef0b764. Consider uploading reports for the commit ef0b764 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #161   +/-   ##
=========================================
  Coverage     97.90%   97.90%           
  Complexity      850      850           
=========================================
  Files            37       37           
  Lines          2524     2524           
=========================================
  Hits           2471     2471           
  Misses           53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7 stronk7 force-pushed the better_integration_tests_exit_codes branch 2 times, most recently from cb7f4ad to ef0b764 Compare May 13, 2024 15:48
@stronk7 stronk7 requested a review from andrewnicols May 13, 2024 15:51
@stronk7
Copy link
Member Author

stronk7 commented May 14, 2024

Tata!

@stronk7 stronk7 merged commit 4d16f38 into moodlehq:main May 14, 2024
24 checks passed
@stronk7 stronk7 deleted the better_integration_tests_exit_codes branch May 14, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants