moved popup and show to constructorProperties #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for deprecation warning Confirm.show should be moved to constructorProperties
|
the more i think about this one, the more i think its just because i was using Confirm.show statically, and maybe it's not supposed to be used statically. https://github.com/montagejs/matte/blob/master/test/popup/popup-spec.js#L112-L125 |
|
It is supposed to be used statically, we didn't use to make the difference between constructor and prototype properties hence the problem in the spec. |
|
ah okay, should i maybe add a test to show the static use to round off the PR? |
|
/poke @francoisfrisch |
|
@kriskowal i dont mind adding the specs if you want to use this ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for deprecation warning
Confirm.show should be moved to constructorPropertiesi was getting this warning in my app, so in my app i had a customized copy of confirm.reel where i moved show and popup to the constructorProperties, and the deprecation warnings went away, but there were never any deprecation warnings with the test suite in matte, maybe i would need to add a test to tease it out... or maybe the example of Confirm.show that i followed is no longer normal, and we should be using an instance ie confirm.show?
tests before the changes (chrome 32.0.1700.107)
tests after the changes (chrome 32.0.1700.107)