Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Fixes compatbaseline check for HttpHeaderKind change #9551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josegallardo
Copy link
Contributor

This is required for insertion PR https://github.com/xamarin/md-addins/pull/6190

@mrward mrward requested a review from dalexsoto January 15, 2020 19:30
@mrward
Copy link
Member

mrward commented Jan 15, 2020

Not sure this is correct. PRs are currently failing since they are building on Mac 10.13 but the master branch is building with Catalina where the compat check is working (was updated by @dalexsoto and this change here seems to revert this change made by Alex - https://github.com/mono/monodevelop/pull/9525/files)

@josegallardo
Copy link
Contributor Author

Not sure this is correct. PRs are currently failing since they are building on Mac 10.13 but the master branch is building with Catalina where the compat check is working (was updated by @dalexsoto and this change here seems to revert this change made by Alex - https://github.com/mono/monodevelop/pull/9525/files)

Then we shouldn't merge this change and just merge the md-addins PRs even with CompatBaseCheck failing?

Looks like that's the case, and we should just close this PR and merge https://github.com/xamarin/md-addins/pull/6190

Thanks @mrward for the quick catch! @dalexsoto can you please confirm?

@josegallardo
Copy link
Contributor Author

Adding the do-not-merge label for now until we can confirm this should be closed.

@mrward
Copy link
Member

mrward commented Jan 16, 2020

Then we shouldn't merge this change and just merge the md-addins PRs even with CompatBaseCheck failing?
Correct. @josegallardo Yeah I would just merge the md-addins change.

Base automatically changed from master to main March 9, 2021 14:17
@akoeplinger akoeplinger changed the base branch from main to master March 15, 2021 17:01
Base automatically changed from master to main March 15, 2021 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants