Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] F# signature gen for members, attributes, records, DUs, and Enums #332

Closed
wants to merge 61 commits into from

Conversation

cartermp
Copy link

@cartermp cartermp commented Aug 21, 2018

Due to #308 I cannot test this (the test projects do not build for me), so here's to hoping that something useful comes out of CI!

Taking on:

#319
#318
#335
#337
#339

@cartermp cartermp changed the title Prepend attributes and list members after interface impls [WIP]Prepend attributes and list members for F# signatures Aug 21, 2018
@cartermp
Copy link
Author

@joelmartinez I've got this now to a point where I think it's good enough to do acceptance testing, but the build still fails after tests pass. Any ideas?

@cartermp
Copy link
Author

Ah durn, looks like there's some XML baselines that need updating. Can a tool do that?

@joelmartinez
Copy link
Member

@cartermp not really in this case (some of those integration tests have ways to automatically update them in cases of breaking changes like this ... but it has to be done via CLI/make, and these f# tests in particular don't have those targets).

I'm working on a few high-pri things right now, but am going to try to make some time today or tomorrow to look at why this isn't building on windows, in addition to making the requisite edits to the test XMLs. Just grant me the ability to modify your branch:
https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/

@cartermp
Copy link
Author

@joelmartinez according to the article you should have rights to edit the branch.

@cartermp cartermp changed the title [WIP]Prepend attributes and list members for F# signatures [WIP] Member gen, attributes, record gen Aug 23, 2018
@cartermp cartermp changed the title [WIP] Member gen, attributes, record gen [WIP] F# signature gen for members, attributes, records, DUs, and Enums Aug 23, 2018
@cartermp
Copy link
Author

@joelmartinez I added a new file, and the project builds locally, but not on CI. The file is a part of these changes. Is there something else I need to do to make it build in CI?

@cartermp
Copy link
Author

never mind, it's old style csproj

@joelmartinez
Copy link
Member

@cartermp I'm now working on updating the baseline XML tests ... I've encountered one regression. Looks like you updated the generic parameter brackets to use { instead of <; however you've done so in a place that affected some of the other formatters (not sure offhand if it's the docid formatter, or the slashdoc formatter, in this case):

-      <Member Id="P:Mono.DocTest.Generic.MyList`2.System#Collections#Generic#ICollection&lt;A&gt;#IsReadOnly" />
-      <Member Id="P:Mono.DocTest.Generic.MyList`2.System#Collections#Generic#IEnumerator&lt;A&gt;#Current" />
+      <Member Id="P:Mono.DocTest.Generic.MyList`2.System#Collections#Generic#ICollection{A}#IsReadOnly" />
+      <Member Id="P:Mono.DocTest.Generic.MyList`2.System#Collections#Generic#IEnumerator{A}#Current" />

This would end up breaking a large amount of systems that depend on the current formatting for those IDs

@mimisasouvanh
Copy link
Collaborator

Internal work item created to track this bug

@joelmartinez
Copy link
Member

This work has unfortunately bit-rotted past the point where it is possible to reasonably re-integrate it with the latest code ... I'm going to close this PR, though we will keep it for reference if/when we have resources in the future to address some of these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants