-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] F# signature gen for members, attributes, records, DUs, and Enums #332
Conversation
@joelmartinez I've got this now to a point where I think it's good enough to do acceptance testing, but the build still fails after tests pass. Any ideas? |
Ah durn, looks like there's some XML baselines that need updating. Can a tool do that? |
@cartermp not really in this case (some of those integration tests have ways to automatically update them in cases of breaking changes like this ... but it has to be done via CLI/make, and these f# tests in particular don't have those targets). I'm working on a few high-pri things right now, but am going to try to make some time today or tomorrow to look at why this isn't building on windows, in addition to making the requisite edits to the test XMLs. Just grant me the ability to modify your branch: |
@joelmartinez according to the article you should have rights to edit the branch. |
@joelmartinez I added a new file, and the project builds locally, but not on CI. The file is a part of these changes. Is there something else I need to do to make it build in CI? |
never mind, it's old style csproj |
1547797
to
e26a22e
Compare
…t get this moving along nah)
e26a22e
to
c1437f1
Compare
Also updated readme to better reflect dependencies
@cartermp I'm now working on updating the baseline XML tests ... I've encountered one regression. Looks like you updated the generic parameter brackets to use
This would end up breaking a large amount of systems that depend on the current formatting for those IDs |
Internal work item created to track this bug |
This work has unfortunately bit-rotted past the point where it is possible to reasonably re-integrate it with the latest code ... I'm going to close this PR, though we will keep it for reference if/when we have resources in the future to address some of these issues. |
Due to #308 I cannot test this (the test projects do not build for me), so here's to hoping that something useful comes out of CI!
Taking on:
#319
#318
#335
#337
#339