-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Typemap cleanup" #1810
Revert "Typemap cleanup" #1810
Conversation
This reverts commit e068f2a.
@tritao Please read carefully.
Basically 5 is generating compilation errors: Summary:
Sorry for the inconvenience. I made a mistake, but looks like others have fallen for the very same one. Edit:These changes were introduces by many PR before #1783, but #1783 introduced C# 10.0 requirement. And these changes weren't submitted by the corresponding PRs as they should've. |
Should we add a new generator option for the C# language target version? Then we could only enable the behavior of #1783 when its >= 10.0. Alternatively, we would need to require C# 10.0 going forward. |
Indeed this is what I am thinking about. Practically speaking C# 10.0 is really new. By the way I located the part which needs fixing in this PR, it is solely related to |
By the way, why do we need this revert? Can we not just fix the C# 10.0 issue with the generation? |
As you like, I can close this PR then and submit a patch which fixes it, basically this typemap should be removed as it was in the first place in the CLI backend: CppSharp/src/Generator/Types/Std/Stdlib.CSharp.cs Lines 415 to 429 in 1327971
Commenting/removing this will fix the issue. @tritao Please have a look too. Logically speaking, why std::map only should have a C# typemap, while std::vector , std::list not? I believe this typemap was inactive while being in the CLI backend while back. But after being refactored to become active in the C# backend, it became undesired.
Notice:While studying the typemaps in this PR, I noticed that the CLI backend had a dependency on C# and not the opposite. So logically speaking, deleting this typemap won't affect other things. We should consider adding tests for containers. |
Reverts #1802