Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-284155 Flaky Test: mongodb-atlas-cli-master-github.com_mongodb_mongodb-atlas-cli_atlascli_test_e2e_atlas.TestClustersM0Flags_Create/atlas_clusters_m0_e2e/e2e_atlas_clusters #3391

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Nov 18, 2024

Proposed changes

Flaky Test: mongodb-atlas-cli-master-github.com_mongodb_mongodb-atlas-cli_atlascli_test_e2e_atlas.TestClustersM0Flags_Create/atlas_clusters_m0_e2e/e2e_atlas_clusters

Jira ticket: CLOUDP-284155

Closes #[issue number]

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

…_mongodb-atlas-cli_atlascli_test_e2e_atlas.TestClustersM0Flags_Create/atlas_clusters_m0_e2e/e2e_atlas_clusters
@fmenezes fmenezes marked this pull request as ready for review November 18, 2024 11:37
@fmenezes fmenezes requested a review from a team as a code owner November 18, 2024 11:37
@@ -39,9 +39,6 @@ func TestClustersM0Flags(t *testing.T) {
clusterName, err := RandClusterName()
req.NoError(err)

mongoDBMajorVersion, err := MongoDBMajorVersion()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now the clusters team is looking into splitting the update of default mdb version and the version for the shared tier which historically were changed at the same time, can you create a ticket to investigate next steps here to avoid having to update this test every year, this also kind of affects the clusters command which the help may say an M0 is created with 7.0 but it'll show as 8.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have any references to right now the clusters team is looking into splitting the update of default mdb version and the version for the shared tier ?

@fmenezes fmenezes merged commit 5438f89 into master Nov 18, 2024
24 checks passed
@fmenezes fmenezes deleted the CLOUDP-284155 branch November 18, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants