Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scrivener_ecto #483

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Bump scrivener_ecto #483

merged 2 commits into from
Oct 25, 2024

Conversation

samhamilton
Copy link
Contributor

Hi,

Saw that you took over the main scrivener_ecto repo but after a new release didn't bump Torch, not sure why not so here is a small pull to move things back to the main package.

Cheers
Sam

@cpjolicoeur
Copy link
Member

Thanks for this @samhamilton . Can you just re-run this once more so that the lockfile gets bumped to the latest 3.0.1 of scrivener_ecto? No reason not to lock to the latest at the current point in time

@samhamilton
Copy link
Contributor Author

@cpjolicoeur sure thing. Ran mix do deps.clean --unlock --unused, deps.update scrivener_ecto which also removed a couple of unused packages from the lock file

@cpjolicoeur
Copy link
Member

@samhamilton thanks for the updates. Some failing test runs though due to lock version issues with base ecto it seems.

Also, please squash these commits into a single commit since they are all related and atomic in nature, thanks.

@samhamilton samhamilton reopened this Oct 15, 2024
@cpjolicoeur
Copy link
Member

@samhamilton I know this is a lot of back and forth, but care to handle the related test failures as part of this. Updating gettext created some warning failures

@dgigafox
Copy link
Contributor

Hey @cpjolicoeur, I just pushed fixes on the test failures. Workflow should be ready to go. 🚀

@cpjolicoeur cpjolicoeur merged commit b086ff1 into mojotech:master Oct 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants