chore(tsconfig): use strict null checks #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, TS considers `null` and `undefined` to be members of _every_ type. This does not match the semantics of EcmaScript and requires devs to sprinkle lots of `null` and `undefined` guards throughout the code. This update fixes that.
geraldalewis
requested review from
thedelchop,
cbarber,
mariana0pachon,
sracca and
theroyalblah
geraldalewis
commented
Jul 30, 2019
| event.preventDefault(); | ||
| setToken(tokenRef.current.value); | ||
| setToken(tokenRef.current!.value); |
There was a problem hiding this comment.
Usually the assertion operator is not the right choice, but we want a noisy failure here in the highly improbable event that tokenRef.current is null.
mariana0pachon
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, TS considers
nullandundefinedto be members ofevery type. This does not match the semantics of EcmaScript and
requires devs to sprinkle lots of
nullandundefinedguardsthroughout the code. This update fixes that.
deep dive
ts docs
For an example in our own codebase, see https://github.com/mojotech/pt-estimator/pull/25/files#diff-21fb8fb9e023edf58649b90783831bedR48