Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MkDocs Iceberg README #129

Open
wants to merge 1 commit into
base: mkdocs
Choose a base branch
from
Open

MkDocs Iceberg README #129

wants to merge 1 commit into from

Conversation

gwionap
Copy link
Contributor

@gwionap gwionap commented Oct 3, 2023

Added readme for the iceberg converters.

Copy link
Contributor

@Thomas-Hirsch Thomas-Hirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start, but it could do with a little bit more explanation at the top, some example usage and possibly some mention in the main readme as well.

Some things worth mentioning/expanding on:

  • brief description of Iceberg - it's a table type in Athena, that is created and populated through SQL queries on existing Hive Athena schemas rather than overlaying a schema onto a bucket of files in S3. It took me a little while to understand that point.
  • why you need IcebergMetadata as a child of Metadata. Can I convert existing Metadata into IcebergMetadata?
  • some example of workflow. I would expect the AthenaIcebergTable class is more likely be used than the SQLConverter, in large part because the former is a wrapper for the latter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants