[stdlib] Addition of a new constructor and reserve method to the String struct
#3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…agic run` to pre-commit configuration. squash code a bit by using write add tests Cleanup with formatting and sign add missing newline Signed-off-by: Mikhail Tavarez <[email protected]> updated changelog
…agic run` to pre-commit configuration. squash code a bit by using write add tests Cleanup with formatting and sign add missing newline Signed-off-by: Mikhail Tavarez <[email protected]> updated changelog updated changelog Add unsetenv and use a context manager to unset test variables. Add renamed test_env.mojo Fix unsetenv result in EnvVar context manager. Signed-off-by: Mikhail Tavarez <[email protected]> use constrained for unsetenv use immutable stringslice
martinvuyk
reviewed
Nov 6, 2024
stdlib/src/collections/string.mojo
Outdated
Comment on lines
2311
to
2316
| If the current capacity is greater or equal, this is a no-op. | ||
| Otherwise, the storage is reallocated and the date is moved. | ||
|
|
||
| Args: | ||
| new_capacity: The new capacity. | ||
| """ |
There was a problem hiding this comment.
nit:
Suggested change
| If the current capacity is greater or equal, this is a no-op. | |
| Otherwise, the storage is reallocated and the date is moved. | |
| Args: | |
| new_capacity: The new capacity. | |
| """ | |
| Args: | |
| new_capacity: The new capacity. | |
| Notes: | |
| If the current capacity is greater or equal, this is a no-op. | |
| Otherwise, the storage is reallocated and the data is moved. | |
| """ |
Signed-off-by: Mikhail Tavarez <[email protected]>
|
Commits are borked here, opening a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a public API for users to allocate capacity through String, instead of having to reach into the private internal
._bufferattribute.Satisfies: #3738
NOTE: Waiting for #3735 to go through so the
pixi.tomlchanges make it through.