Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] [NFC] Rename Span UnsafePointer constructor args #3743

Conversation

martinvuyk
Copy link
Contributor

Rename Span UnsafePointer constructor args. Part of #3704

@martinvuyk martinvuyk requested a review from a team as a code owner November 5, 2024 15:33
Signed-off-by: martinvuyk <[email protected]>
@JoeLoser
Copy link
Collaborator

JoeLoser commented Nov 7, 2024

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Nov 7, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added merged-internally Indicates that this pull request has been merged internally merged-externally Merged externally in public mojo repo labels Nov 9, 2024
@modularbot
Copy link
Collaborator

Landed in 0fda0e2! Thank you for your contribution 🎉

modularbot added a commit that referenced this pull request Nov 9, 2024
…rgs (#50488)

[External] [stdlib] [NFC] Rename `Span` `UnsafePointer` constructor args

Rename `Span` `UnsafePointer` constructor args. Part of
#3704.

ORIGINAL_AUTHOR=martinvuyk
<[email protected]>
PUBLIC_PR_LINK=#3743

Co-authored-by: martinvuyk <[email protected]>
Closes #3743
MODULAR_ORIG_COMMIT_REV_ID: 4845b40b59eaa55827b4ee42240b7f9361d4a608
@modularbot modularbot closed this Nov 9, 2024
@martinvuyk martinvuyk deleted the rename-span-unsafeptr-constructor branch November 9, 2024 11:35
modularbot added a commit that referenced this pull request Dec 17, 2024
…rgs (#50488)

[External] [stdlib] [NFC] Rename `Span` `UnsafePointer` constructor args

Rename `Span` `UnsafePointer` constructor args. Part of
#3704.

ORIGINAL_AUTHOR=martinvuyk
<[email protected]>
PUBLIC_PR_LINK=#3743

Co-authored-by: martinvuyk <[email protected]>
Closes #3743
MODULAR_ORIG_COMMIT_REV_ID: 4845b40b59eaa55827b4ee42240b7f9361d4a608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants