-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] [NFC] Rename Span
UnsafePointer
constructor args
#3743
Closed
martinvuyk
wants to merge
3
commits into
modularml:nightly
from
martinvuyk:rename-span-unsafeptr-constructor
Closed
[stdlib] [NFC] Rename Span
UnsafePointer
constructor args
#3743
martinvuyk
wants to merge
3
commits into
modularml:nightly
from
martinvuyk:rename-span-unsafeptr-constructor
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
JoeLoser
approved these changes
Nov 7, 2024
!sync |
modularbot
added
the
imported-internally
Signals that a given pull request has been imported internally.
label
Nov 7, 2024
…feptr-constructor
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
Indicates that this pull request has been merged internally
merged-externally
Merged externally in public mojo repo
labels
Nov 9, 2024
Landed in 0fda0e2! Thank you for your contribution 🎉 |
modularbot
added a commit
that referenced
this pull request
Nov 9, 2024
…rgs (#50488) [External] [stdlib] [NFC] Rename `Span` `UnsafePointer` constructor args Rename `Span` `UnsafePointer` constructor args. Part of #3704. ORIGINAL_AUTHOR=martinvuyk <[email protected]> PUBLIC_PR_LINK=#3743 Co-authored-by: martinvuyk <[email protected]> Closes #3743 MODULAR_ORIG_COMMIT_REV_ID: 4845b40b59eaa55827b4ee42240b7f9361d4a608
modularbot
added a commit
that referenced
this pull request
Dec 17, 2024
…rgs (#50488) [External] [stdlib] [NFC] Rename `Span` `UnsafePointer` constructor args Rename `Span` `UnsafePointer` constructor args. Part of #3704. ORIGINAL_AUTHOR=martinvuyk <[email protected]> PUBLIC_PR_LINK=#3743 Co-authored-by: martinvuyk <[email protected]> Closes #3743 MODULAR_ORIG_COMMIT_REV_ID: 4845b40b59eaa55827b4ee42240b7f9361d4a608
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
imported-internally
Signals that a given pull request has been imported internally.
merged-externally
Merged externally in public mojo repo
merged-internally
Indicates that this pull request has been merged internally
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
Span
UnsafePointer
constructor args. Part of #3704